-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverted widespread editor.focus() usage back to editor.editing.view.focus() form #8414
Conversation
…s()" This reverts commit a8c8328.
…ation. Today we're always focusing the editable view, that's true - but at some point we might be focusing the UI parts.
I've added a bit more explanation to the |
And as I have this checked-out I might review this as well. |
# Conflicts: # packages/ckeditor5-widget/tests/widgetresize/_utils/utils.js
Sorry for the force-push... I've accidentally pushed my research on DLLs ( 😉 ). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks, like we have all the reverts needed.
Suggested merge commit message (convention)
Revert: Reverted widespread
editor.focus()
usage back toeditor.editing.view.focus()
form. Closes #714.Additional information
Per #714 (comment) though
editor.focus()
today always focuses the editing view - it's not said that it always will be.It also brings back
editor.editing.view.focus()
mentions in the docs while also adding a mentioneditor.focus()
.